Open
Conversation
ayushuk
approved these changes
Jan 22, 2024
Member
ayushuk
left a comment
ayushuk
left a comment
There was a problem hiding this comment.
On hold, will be merged after the 3.5.0 release
Member
|
@mayankpatibandla Can you solve the conflicts in the meantime? |
ayushuk
added
on hold
Member
Author
|
Conflicts have been resolved |
Member
|
Lets wait to merge this after 3.5.1 since we want to get that out quickly and then when everything is stable again we can merge this and start enforcing it. |
mayankpatibandla
changed the title
mayankpatibandla
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds pre-commit to run some hooks that must pass before a commit is allowed. Some basic errors regarding whitespace and unused variables have been fixed. Also adds Pylint to GitHub actions.
Motivation:
The goal is to enforce a more consistent coding style and fix linting issues. Currently most errors have been disabled, but we will need to enable some of them later to comply to a chosen standard.
References (optional):
#300
Test Plan:
pip install pre-commitif you don't already have it, and then runpre-commit installin the project directory. Pre-commit hooks should now run automatically every time a new commit is made.pre-commit run --all-filespasses for all files in the project.